Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted fix for Reverse Area 8 crash #379

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Attempted fix for Reverse Area 8 crash #379

merged 4 commits into from
Jun 17, 2024

Conversation

dyceron
Copy link
Collaborator

@dyceron dyceron commented Jun 17, 2024

Current attempt to fix the crash for Reverse Area 8 in RomFS mode. Related to #378

This solution currently checks if the Queen wall exists or not (essentially if RA8 is enabled or disabled). If the option is disabled, vanilla behavior occurs, and the ccs will update their setups when all the Metroids are dead. If it's enabled, never update the setups.

It would be nice to know why this breaks with RomFS mode and not PKG mode instead of doing this, as this is not the most elegant solution, but it does get the job done.

@dyceron dyceron marked this pull request as ready for review June 17, 2024 04:34
@dyceron dyceron requested a review from ThanatosGit June 17, 2024 04:34
@dyceron dyceron changed the title Attempted fix for Reverse Area 8 Attempted fix for Reverse Area 8 crash Jun 17, 2024
Copy link
Collaborator

@ThanatosGit ThanatosGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, at some point it would be nice to fix the issues instead of hacking around it.

src/open_samus_returns_rando/files/levels/s100_area10.lua Outdated Show resolved Hide resolved
@dyceron dyceron merged commit 4af0f56 into main Jun 17, 2024
6 checks passed
@dyceron dyceron deleted the ra8-fix branch June 17, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants