Disable the intro spawn trigger for the newborn alpha if already dead

[dyceron]

Fixes #318

[dyceron]

Tested this a couple of times and the Alpha never respawned.

[ThanatosGit]

Hmmm for me the alpha still respawns if you go there from the front.
I added some output. As you can see the Dead callback is not called when you go there from the front and the trigger seems to be still active.
It's only called from the back and - as you can see from the output - after I killed the alpha the first time and being at the missile block.

@ThanatosGit Nice typos in the log messages 🙃

2024-04-14.08-34-33.mp4

[dyceron]

That's so odd. This Alpha is always causing issues.

[ThanatosGit]

open-samus-returns-rando/src/open_samus_returns_rando/files/templates/metroid_template.lua

Lines 37 to 42 in f16dee6

	Game.SetInGameMusicState("RELAX")
	if scenario == "s000_surface" then
	Game.DisableEntity("TG_Intro_Alpha")
	Scenario.WriteToBlackboard("alpha_killed", "b", true)
	end
	Game.SaveGame("checkpoint", "AfterNewAbilityAcquired", "", true)

Oops, this should be Game.DisableTrigger("TG_Intro_Alpha"). Then no other change should be required.

[dyceron]

If you could test this for me, that'd be great.

[ThanatosGit]

Works. The changes in s000_surface.lua are not required because DisableTrigger from the metroid template is persistent.

[dyceron]

Wait so should anything else still be changed or those this good to go?

[ThanatosGit]

Wait so should anything else still be changed or those this good to go?

Isn't that twice the same case 😛?
Feel free to merge it that way.

The changs in s000_surface.lua didn't make a difference for me.
Kinda makes sense?
We never set the AlphaIntroPlayed property because we completly block playing that cutscene.
The additional part in s000_surface.OnEnter_Alpha_001_Dead is alredy handled by the metroid_template.lua.
OnDNAAbsorbAnimation should also never be executed because we don't play this animation. That's also the reason why the alpha_killed part is in the metroid_template.lua.