-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for hidden powerups #309
Conversation
This looks fine to me. I was hesitant to do it this way for all the blocks because the one in s067 cc7 has a logical clip to get it without Screw Attack, and now it technically can be grabbed without Bombs if you are standing on top of it. Could always prevent this by making the hitbox of that actor smaller so it can't be grabbed without Bombs. |
Otherwise, these should be all of the problematic blocks. I checked over the whole map and these were the only ones that were affected from the wrong cc. We could fix the cheese I mentioned, but pr looks good to go whenever. |
Do you had a look at all patched items here? I think, I only tested like 2 or 3 that's why I don't know if everything is fine. |
I haven't had the time to test these, but I can later. If it's good I'll merge the pr. |
So I tested all 5 of these locations and had no issues, so it seems fine (I couldn't replicate the wrong room thing to begin with). The only issue like I've mentioned is some blocks can be grabbed from above due to the item position and the size of the item, but I guess that's something we'll have to deal with. Also, if the model/texture/fx are large then the item can be barely seen protruding from the block (Aeion Abilities for example). This isn't necessarily a bad thing, but not a huge deal either. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If we want to do more testing/the minor adjustments to fix the less important stuff then we can, otherwise feel free to merge this.
Can't reproduce anymore either with this branch, so that does seem good indeed |
The tile which hides the HiddenPowerup003 was always visible if destroyed from adjacent room and I had no idea how to fix it.
Then I decided to not add the items to any other cc group but just do the "freestanding + place block on top of it" approach for all items.
Haven't looked at all items yet but I leave it here for now.
Fixes #308