Only enable Missile Reserve Tank if Missile Launcher is in inventory #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThanatosGit
reviewed
Feb 21, 2024
Comment on lines
27
to
33
| if _FORV_3_ == "ITEM_RESERVE_TANK_MISSILE" and Blackboard.GetProp("PLAYER_INVENTORY", "ITEM_WEAPON_MISSILE_LAUNCHER") then | ||
| Blackboard.SetProp("GAME", "ITEM_RESERVE_TANK_MISSILE_ACTIVE", "b", true) | ||
| Blackboard.SetProp("GAME", "ITEM_RESERVE_TANK_MISSILE_FULL", "b", true) | ||
| elseif _FORV_3_ ~= "ITEM_RESERVE_TANK_MISSILE" then | ||
| Blackboard.SetProp("GAME", _FORV_3_ .. "_ACTIVE", "b", true) | ||
| Blackboard.SetProp("GAME", _FORV_3_ .. "_FULL", "b", true) | ||
| end |
There was a problem hiding this comment.
Both flows doing the exact same thing. Can just be combined in one if-clause with an or.
ThanatosGit
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the current implementation of shuffled Missile Launcher, this is the simplest solution to preventing the Missile Reserve Tank from activating on its own without Missiles. Now, it checks for Missile Launcher in the inventory to activate. The only downside is that having only Super Launcher means you can't utilize the Reserve Tank to your advantage. Maybe in the future we can have the Reserve Tank be independent of the Launcher, but this is the best option I'm willing to take for now.
Fixes #253