Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ITEM_MAX_SPECIAL_ENERGY as required #103

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Add ITEM_MAX_SPECIAL_ENERGY as required #103

merged 1 commit into from
Sep 23, 2023

Conversation

ThanatosGit
Copy link
Collaborator

@ThanatosGit ThanatosGit commented Sep 23, 2023

My patcher file was not complaining but the patcher crashed. Looks like it is now required :p

@ThanatosGit ThanatosGit requested a review from dyceron September 23, 2023 11:47
@dyceron
Copy link
Collaborator

dyceron commented Sep 23, 2023

Might this be because we now have the "pop" for aeion?

@ThanatosGit
Copy link
Collaborator Author

Yeah, that's why it crashed. I much prefer a validation error (which also tells me my vs code while editing) instead of a random code crash => That's why I added it to the required section in the schema

@dyceron dyceron merged commit 16707a1 into main Sep 23, 2023
6 checks passed
@ThanatosGit ThanatosGit deleted the fix-starting-items branch October 1, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants