Add Hudmemo's to Dark Oasis and Hive Chamber A #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## replace-claris-patcher #92 +/- ##
==========================================================
+ Coverage 87.16% 87.31% +0.14%
==========================================================
Files 39 39
Lines 1714 1734 +20
==========================================================
+ Hits 1494 1514 +20
Misses 220 220 ☔ View full report in Codecov by Sentry. |
|
Why was this PR closed? was this already integrated in #101 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed the GFMC example.
Only concern would be the size of the Dark Oasis trigger as you might need to walk around a bit for it. Could expand the xy dimensions to cover more of the pool.