MSR - Support .bmsmd #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 73.84% 73.94% +0.10%
==========================================
Files 60 61 +1
Lines 3101 3113 +12
==========================================
+ Hits 2290 2302 +12
Misses 811 811
☔ View full report in Codecov by Sentry. |
ThanatosGit
requested changes
Nov 8, 2023
tests/formats/test_bmsmd.py
Outdated
|
|
||
| def test_bmsmd(samus_returns_path): | ||
| file_path = samus_returns_path.joinpath(r"gui\minimaps\c10_samus.bmsmd") | ||
| parse_and_build_compare( |
There was a problem hiding this comment.
Can you use the parse_build_compare_editor here instead? Then the uncovered construct_class method would be in the tests, too.
ThanatosGit
requested changes
Nov 8, 2023
tests/formats/test_bmsmd.py
Outdated
| from mercury_engine_data_structures.formats.bmsmd import Bmsmd | ||
|
|
||
|
|
||
| def test_bmsmd(samus_returns_tree, bmsmd_path): |
There was a problem hiding this comment.
def test_bmsmd(samus_returns_tree):
bmsmd_path is defined one line later and is not a parameter.
tests/formats/test_bmsmd.py
Outdated
| def test_bmsmd(samus_returns_tree, bmsmd_path): | ||
| bmsmd_path = samus_returns_path.joinpath(r"gui\minimaps\c10_samus.bmsmd") | ||
| parse_build_compare_editor( | ||
| Bmsmd, samus_returns_tree, file_path |
There was a problem hiding this comment.
bmsd_path not file_path. file_path is nowhere defined.
ThanatosGit
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what most of these unknowns are and I don't know if all the data types in
sub_scenariosis 100% correct.