Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSR - Add bmses support #95

Merged
merged 4 commits into from
Nov 6, 2023
Merged

MSR - Add bmses support #95

merged 4 commits into from
Nov 6, 2023

Conversation

dyceron
Copy link
Contributor

@dyceron dyceron commented Nov 5, 2023

Environment Sounds for Samus Returns

I was able to figure out most of the unknowns. I'll do more testing another time to figure out the rest

@dyceron dyceron requested a review from ThanatosGit November 5, 2023 09:35
@github-actions github-actions bot enabled auto-merge November 5, 2023 09:36
@github-actions github-actions bot added this pull request to the merge queue Nov 5, 2023
@dyceron dyceron removed this pull request from the merge queue due to a manual request Nov 5, 2023
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1889d0) 73.73% compared to head (b696001) 73.84%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   73.73%   73.84%   +0.11%     
==========================================
  Files          59       60       +1     
  Lines        3088     3101      +13     
==========================================
+ Hits         2277     2290      +13     
  Misses        811      811              
Files Coverage Δ
...mercury_engine_data_structures/formats/__init__.py 100.00% <100.00%> (ø)
...rc/mercury_engine_data_structures/formats/bmses.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ThanatosGit ThanatosGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Changing to the const would be nice but not required.
Change and merge or just merge it ;)

src/mercury_engine_data_structures/formats/bmses.py Outdated Show resolved Hide resolved
@github-actions github-actions bot enabled auto-merge November 6, 2023 00:39
@github-actions github-actions bot added this pull request to the merge queue Nov 6, 2023
@dyceron dyceron removed this pull request from the merge queue due to a manual request Nov 6, 2023
@dyceron dyceron added this pull request to the merge queue Nov 6, 2023
Merged via the queue into randovania:main with commit 9f37014 Nov 6, 2023
9 checks passed
@dyceron dyceron deleted the bmses branch November 6, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants