-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSR - Add bmses support #95
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 73.73% 73.84% +0.11%
==========================================
Files 59 60 +1
Lines 3088 3101 +13
==========================================
+ Hits 2277 2290 +13
Misses 811 811
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Changing to the const would be nice but not required.
Change and merge or just merge it ;)
Environment Sounds for Samus Returns
I was able to figure out most of the unknowns. I'll do more testing another time to figure out the rest