Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply alignment after header in pkg #79

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

ThanatosGit
Copy link
Contributor

No idea how to provide tests due to the fact that the padding within the pkg looks totally random. (some pkg's even have odd number of bytes)

@ThanatosGit ThanatosGit requested a review from a team September 19, 2023 18:12
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (48a7447) 73.13% compared to head (f86bb25) 73.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   73.13%   73.11%   -0.02%     
==========================================
  Files          56       56              
  Lines        3030     3028       -2     
==========================================
- Hits         2216     2214       -2     
  Misses        814      814              
Files Changed Coverage Δ
src/mercury_engine_data_structures/formats/pkg.py 79.33% <100.00%> (-0.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@henriquegemignani henriquegemignani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh well 🤷

@henriquegemignani henriquegemignani added this pull request to the merge queue Sep 19, 2023
Merged via the queue into randovania:main with commit f426b8f Sep 19, 2023
9 checks passed
@ThanatosGit ThanatosGit deleted the fix-sr-pkg branch September 20, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants