Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMSCC Refactor #251

Merged
merged 16 commits into from
Dec 23, 2024
Merged

BMSCC Refactor #251

merged 16 commits into from
Dec 23, 2024

Conversation

dyceron
Copy link
Contributor

@dyceron dyceron commented Dec 19, 2024

  • Cleans up formatting
  • Adds functions to modify points and access other collision data

@dyceron
Copy link
Contributor Author

dyceron commented Dec 20, 2024

I managed to keep construct.Terminated but I don't think this is the best way to go about it. I would like feedback on how to approach this so only Dread uses that last field, since it doesn't exist for MSR. @duncathan

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.93%. Comparing base (9c509cf) to head (a58f641).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...rc/mercury_engine_data_structures/formats/bmscc.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   76.85%   76.93%   +0.08%     
==========================================
  Files          78       78              
  Lines        3876     3894      +18     
==========================================
+ Hits         2979     2996      +17     
- Misses        897      898       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dyceron
Copy link
Contributor Author

dyceron commented Dec 20, 2024

I guess I got it? I have no clue what I did lol. I just copied from BMSAD.

@ThanatosGit
Copy link
Contributor

I guess I got it? I have no clue what I did lol. I just copied from BMSAD.

Looks right to me. e.g. for autclast.bmscd you get this:

    parts = ListContainer: 
        Container: 
            group = u'default' (total 7)
            components = ListContainer: 
                Container: 
                    name = u'Body' (total 4)
                Container: 
                    name = u'LeftArm' (total 7)
                Container: 
                    name = u'LeftHammer' (total 10)
                Container: 
                    name = u'RightArm' (total 8)
                Container: 
                    name = u'RightHammer' (total 11)

@dyceron dyceron linked an issue Dec 21, 2024 that may be closed by this pull request
@dyceron dyceron requested a review from duncathan December 21, 2024 15:06
Copy link
Member

@henriquegemignani henriquegemignani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same docstring change for the other methods

src/mercury_engine_data_structures/formats/bmscc.py Outdated Show resolved Hide resolved
@dyceron dyceron requested a review from duncathan December 22, 2024 22:43
@dyceron dyceron requested a review from duncathan December 23, 2024 04:19
@duncathan duncathan added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 688cc5f Dec 23, 2024
11 checks passed
@duncathan duncathan deleted the bmscc branch December 23, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve GreedyBytes at the end of BMSCC
6 participants