-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BMSEV #205
base: main
Are you sure you want to change the base?
Add BMSEV #205
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 76.69% 76.77% +0.08%
==========================================
Files 74 75 +1
Lines 3446 3458 +12
==========================================
+ Hits 2643 2655 +12
Misses 803 803 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it even known what this file is for? lol
BMSEV = Struct( | ||
"magic" / Const(b"MSEV"), | ||
"version" / VersionAdapter(), | ||
"elements" / make_vector(Struct( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can probably use make_dict()
instead
Compare it with dread's BREV, I assume its the same thing but not using reflection system. mercury-engine-data-structures/src/mercury_engine_data_structures/dread_types.json Line 12968 in bbce177
I'd need to count fields to figure it out for sure but it looks like floats[1:4] may be the fog color. and probably a couple other colors in there as well. |
Simple format but no idea what this is for or what is the meaning of all the floats.
Don't know if it makes sense to merge it like that but I leave it here for now.
Fixes #166
Example: