Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter names #140

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

ThanatosGit
Copy link
Contributor

Breaks OSRR

@ThanatosGit ThanatosGit requested a review from a team May 16, 2024 14:26
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.14%. Comparing base (ee5ae24) to head (20b5f31).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   74.14%   74.14%           
=======================================
  Files          63       63           
  Lines        3156     3156           
=======================================
  Hits         2340     2340           
  Misses        816      816           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henriquegemignani
Copy link
Member

What exactly breaks OSRR? The lack of these fields or adding these?

@ThanatosGit
Copy link
Contributor Author

Adding these.
E.g. OSRR changes the CallbackName for metroids and doors in the death animation. They now reference this stuff by using the CRC and with changes here, they need to reference it by the name.

@henriquegemignani
Copy link
Member

Oh, meds isn't 1.0 anyway so this is just a minor bump anyway

@ThanatosGit ThanatosGit added this pull request to the merge queue May 20, 2024
Merged via the queue into randovania:main with commit 628ab4a May 20, 2024
10 checks passed
@ThanatosGit ThanatosGit deleted the add-crc-names branch May 20, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants