Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BorderType enum to bmsmsd #139

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

dyceron
Copy link
Contributor

@dyceron dyceron commented May 14, 2024

Adds an enum to BorderType in the bmsmsd. It's kinda weird and a lot, but it covers all of the tile borders.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.14%. Comparing base (71851d0) to head (2802c6a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   74.13%   74.14%           
=======================================
  Files          63       63           
  Lines        3155     3156    +1     
=======================================
+ Hits         2339     2340    +1     
  Misses        816      816           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@duncathan duncathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a FlagsEnum with just 8 entries (4 normal edges, 4 hidden edges)

@dyceron
Copy link
Contributor Author

dyceron commented May 14, 2024

this should be a FlagsEnum with just 8 entries (4 normal edges, 4 hidden edges)

You mean instead of the big enum? Idk what that is.

@duncathan
Copy link
Contributor

@dyceron
Copy link
Contributor Author

dyceron commented May 14, 2024

I sorta understand but what to map the enum values to is confusing

@duncathan
Copy link
Contributor

the values you have for 1, 2, 4, 8, 16, 32, 64, and 128

@dyceron dyceron requested a review from duncathan May 14, 2024 04:48
@dyceron dyceron added this pull request to the merge queue May 14, 2024
@dyceron dyceron removed this pull request from the merge queue due to a manual request May 14, 2024
@dyceron dyceron enabled auto-merge May 14, 2024 04:54
@dyceron dyceron added this pull request to the merge queue May 14, 2024
Merged via the queue into randovania:main with commit ee5ae24 May 14, 2024
8 checks passed
@dyceron dyceron deleted the update-bmsmsd branch May 14, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants