-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BorderType
enum to bmsmsd
#139
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=======================================
Coverage 74.13% 74.14%
=======================================
Files 63 63
Lines 3155 3156 +1
=======================================
+ Hits 2339 2340 +1
Misses 816 816 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a FlagsEnum
with just 8 entries (4 normal edges, 4 hidden edges)
You mean instead of the big enum? Idk what that is. |
I sorta understand but what to map the enum values to is confusing |
the values you have for 1, 2, 4, 8, 16, 32, 64, and 128 |
Adds an enum to
BorderType
in the bmsmsd. It's kinda weird and a lot, but it covers all of the tile borders.