Address reviews

src/mercury_engine_data_structures/formats/bmtun.py

@@ -1,13 +1,12 @@
 from __future__ import annotations
 
 import functools
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING
 
 import construct
 from construct.core import (
     Const,
     Construct,
-    Container,
     Flag,
     Int32sl,
     Struct,
@@ -50,14 +49,17 @@ class Bmtun(BaseResource):
     def construct_class(cls, target_game: Game) -> Construct:
         return BMTUN
 
-    def get_tunable(self, tunable: str, param: str) -> Container:
+    def _check_tunable_exists(self, class_name: str, tunable_name: str) -> None:
         classes = self.raw.classes
-        if tunable not in classes:
-            raise ValueError(f"Unknown tunable: {tunable}!")
-        if param not in classes[tunable].tunables:
-            raise ValueError(f"Unknown tunable param: {param}!")
-        return self.raw.classes[tunable].tunables[param]
-
-    def set_tunable(self, tunable_name: str, param: str, value: Any) -> None:
-        tunable = self.get_tunable(tunable_name, param)
-        tunable.value = value
+        if class_name not in classes:
+            raise KeyError(f"Unknown tunable: {class_name}!")
+        if tunable_name not in classes[class_name].tunables:
+            raise KeyError(f"Unknown tunable param: {tunable_name}!")
+
+    def get_tunable(self, class_name: str, tunable_name: str) -> None:
+        self._check_tunable_exists(class_name, tunable_name)
+        return self.raw.classes[class_name].tunables[tunable_name].value
+
+    def set_tunable(self, class_name: str, tunable_name: str, value: str | float | bool | int | list[float]) -> None:
+        self._check_tunable_exists(class_name, tunable_name)
+        self.raw.classes[class_name].tunables[tunable_name].value = value

tests/formats/test_bmtun.py

@@ -18,12 +18,12 @@ def bmtun(samus_returns_tree) -> Bmtun:
 
 
 def test_get_tunable(bmtun):
-    assert bmtun.get_tunable("Amiibo|CTunableReserveTanks", "fLifeTankSize").value == 299.0
+    assert bmtun.get_tunable("Amiibo|CTunableReserveTanks", "fLifeTankSize") == 299.0
 
 
 def test_set_tunable(bmtun):
     bmtun.set_tunable("Amiibo|CTunableReserveTanks", "fLifeTankSize", 199.0)
     assert bmtun.get_tunable("Amiibo|CTunableReserveTanks", "fLifeTankSize") == 199.0
 
-    with pytest.raises(ValueError):
-        bmtun.set_tunable("Amiibo|CTunableReserveTanks", "fSETankSize", True)
+    bmtun.set_tunable("CTunableMissile", "sDamageSource", "BOMB")
+    assert bmtun.get_tunable("CTunableMissile", "sDamageSource") == "BOMB"