YAMS: Flightlight/Blindfold update #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added: Blindfold to darken rooms - TODO: better flashlight sprites
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 30 30
=========================================
Hits 30 30 ☔ View full report in Codecov by Sentry. |
Miepee
reviewed
Oct 7, 2023
Comment on lines
+365
to
+378
| new UndertaleSprite.TextureEntry() {Texture = gmData.TexturePageItems[nameToPageItemDict["sItemFlashlight_1"]] }, | ||
| new UndertaleSprite.TextureEntry() {Texture = gmData.TexturePageItems[nameToPageItemDict["sItemFlashlight_2"]] }, | ||
| new UndertaleSprite.TextureEntry() {Texture = gmData.TexturePageItems[nameToPageItemDict["sItemFlashlight_1"]] }, | ||
| } | ||
| }); | ||
| gmData.Sprites.Add(new UndertaleSprite() | ||
| { | ||
| Name = gmData.Strings.MakeString("sItemBlindfold"), Height = 16, Width = 16, MarginRight = 15, MarginBottom = 15, OriginX = 0, OriginY = 16, | ||
| Textures = | ||
| { | ||
| new UndertaleSprite.TextureEntry() {Texture = gmData.TexturePageItems[nameToPageItemDict["sItemBlindfold_1"]] }, | ||
| new UndertaleSprite.TextureEntry() {Texture = gmData.TexturePageItems[nameToPageItemDict["sItemBlindfold_2"]] }, | ||
| new UndertaleSprite.TextureEntry() {Texture = gmData.TexturePageItems[nameToPageItemDict["sItemBlindfold_3"]] }, | ||
| new UndertaleSprite.TextureEntry() {Texture = gmData.TexturePageItems[nameToPageItemDict["sItemBlindfold_2"]] }, |
There was a problem hiding this comment.
This is probably fine for now. I was thinking in the future of refactoring sprite adding to just "import everyting in order by sprite name that exists" (so thatt i..e i can just add a new frame without needing to modify code) in which case this would break.
Miepee
reviewed
Oct 10, 2023
Miepee
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with both flashlights and blindfolds at various lightlevels (0, 1, 2 ,3, 4) and they adjust properly.