Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tanks instead of Expansions #189

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Use Tanks instead of Expansions #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ All notable changes to this project will be documented in this file.

This format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html)

## [2.0.0] - 2024-04-09

### Changed
- The JSON input now uses (Super) Missile/Power Bomb *Tanks* instead of Expansions.

## [1.2.15] - 2024-03-13

### Fixed
Expand Down
6 changes: 3 additions & 3 deletions YAMS-LIB/SeedObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
{
[JsonInclude]
[JsonPropertyName("configuration_identifier")]
public ConfigurationIdentifier Identifier;

Check warning on line 15 in YAMS-LIB/SeedObject.cs

View workflow job for this annotation

GitHub Actions / Build YAMS-Lib and Python Wheel 

Non-nullable field 'Identifier' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

[JsonInclude]
[JsonPropertyName("game_patches")]
public GamePatches Patches;

Check warning on line 19 in YAMS-LIB/SeedObject.cs

View workflow job for this annotation

GitHub Actions / Build YAMS-Lib and Python Wheel 

Non-nullable field 'Patches' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

[JsonInclude]
[JsonPropertyName("door_locks")]
public Dictionary<uint, DoorLock> DoorLocks;

Check warning on line 23 in YAMS-LIB/SeedObject.cs

View workflow job for this annotation

GitHub Actions / Build YAMS-Lib and Python Wheel 

Non-nullable field 'DoorLocks' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

[JsonInclude]
[JsonPropertyName("pickups")]
Expand All @@ -40,7 +40,7 @@

[JsonInclude]
[JsonPropertyName("starting_location")]
public StartingLocationObject StartingLocation;

Check warning on line 43 in YAMS-LIB/SeedObject.cs

View workflow job for this annotation

GitHub Actions / Build YAMS-Lib and Python Wheel 

Non-nullable field 'StartingLocation' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

[JsonInclude]
[JsonPropertyName("hints")]
Expand All @@ -48,7 +48,7 @@

[JsonInclude]
[JsonPropertyName("cosmetics")]
public GameCosmetics Cosmetics;

Check warning on line 51 in YAMS-LIB/SeedObject.cs

View workflow job for this annotation

GitHub Actions / Build YAMS-Lib and Python Wheel 

Non-nullable field 'Cosmetics' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

[JsonInclude]
[JsonPropertyName("credits_spoiler")]
Expand Down Expand Up @@ -438,11 +438,11 @@
[EnumMember(Value = "Metroid DNA 46")]
DNA46,

[EnumMember(Value = "Missile Expansion")]
[EnumMember(Value = "Missile Tank")]
MissileExpansion,
[EnumMember(Value = "Super Missile Expansion")]
[EnumMember(Value = "Super Missile Tank")]
SuperMissileExpansion,
[EnumMember(Value = "Power Bomb Expansion")]
[EnumMember(Value = "Power Bomb Tank")]
PBombExpansion,
[EnumMember(Value = "Energy Tank")]
EnergyTank,
Expand Down Expand Up @@ -529,10 +529,10 @@
{
[JsonInclude]
[JsonPropertyName("item_id")]
public string ItemID;

Check warning on line 532 in YAMS-LIB/SeedObject.cs

View workflow job for this annotation

GitHub Actions / Build YAMS-Lib and Python Wheel 

Non-nullable field 'ItemID' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
[JsonInclude]
[JsonPropertyName("sprite_details")]
public SpriteDetails SpriteDetails;

Check warning on line 535 in YAMS-LIB/SeedObject.cs

View workflow job for this annotation

GitHub Actions / Build YAMS-Lib and Python Wheel 

Non-nullable field 'SpriteDetails' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
[JsonInclude]
[JsonPropertyName("item_effect")]
public ItemEnum ItemEffect;
Expand All @@ -542,7 +542,7 @@

[JsonInclude]
[JsonPropertyName("text")]
public TextDetails Text;

Check warning on line 545 in YAMS-LIB/SeedObject.cs

View workflow job for this annotation

GitHub Actions / Build YAMS-Lib and Python Wheel 

Non-nullable field 'Text' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

}

Expand Down
Loading