Skip to content

Commit

Permalink
remove/rephrase todos
Browse files Browse the repository at this point in the history
  • Loading branch information
Miepee committed Oct 20, 2023
1 parent 803987c commit 52de066
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions am2r_yams/wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
# TODO: revise this to be cleaner. Following things to keep in mind here
# 1. AFAIK the DLLs must be in path before loading the CLR. test whether that's truly the case.
# Maybe we can remove from path when we're done?
# 2. Figure out how to deal with non-system dotnet installations
# 2. While we figured out how to deal with non system installations via the DOTNET_ROOT env var,
# should we also provide a way to just pass a `dotnet_root` param to the wrapper which gets
# passed to pythonnet?
yams_path = os.fspath(Path(__file__).with_name(name="yams"))
sys.path.append(yams_path)
from pythonnet import load, unload
Expand Down Expand Up @@ -65,8 +67,6 @@ def patch_game(
if profile_xml_path.exists():
profile_xml_path.unlink()

# TODO: this is where we'd call the patcher to do some customization options like music shuffler or samus palettes

# Patch data.win
progress_update("Patching data file...", 0.6)
self.csharp_patcher.Main(input_data_win, output_data_win, json_file)
Expand Down

0 comments on commit 52de066

Please sign in to comment.