release DB cursor before emitting signals

src/database.py

@@ -189,20 +189,23 @@ def initTable_RPC(self, cursor):
     General methods
     '''  
     def clearTable(self,  table_name):
+        cleared_RPC = False
         try:
             cursor = self.getCursor()
             cursor.execute("DELETE FROM %s" % table_name)
             # in case, reload default RPC and emit changed signal
             if table_name == 'CUSTOM_RPC_SERVERS':
                 self.initTable_RPC(cursor)
-                self.app.sig_changed_rpcServers.emit()
+                cleared_RPC = True
 
         except Exception as e:
             err_msg = 'error clearing %s in database' % table_name
             printException(getCallerName(), getFunctionName(), err_msg, e.args)
 
         finally:
             self.releaseCursor()
+            if cleared_RPC:
+                self.app.sig_changed_rpcServers.emit()
 
 
 
@@ -211,26 +214,29 @@ def clearTable(self,  table_name):
     RPC servers methods
     '''
     def addRPCServer(self, protocol, host, user, passwd):
+        added_RPC = False
         try:
             cursor = self.getCursor()
 
             cursor.execute("INSERT INTO CUSTOM_RPC_SERVERS (protocol, host, user, pass) "
                            "VALUES (?, ?, ?, ?)",
                            (protocol, host, user, passwd)
                            )
-
-            self.app.sig_changed_rpcServers.emit()
+            added_RPC = True
 
         except Exception as e:
             err_msg = 'error adding RPC server entry to DB'
             printException(getCallerName(), getFunctionName(), err_msg, e.args)      
         finally:
             self.releaseCursor()
+            if added_RPC:
+                self.app.sig_changed_rpcServers.emit()
 
 
 
 
     def editRPCServer(self, protocol, host, user, passwd, id):
+        changed_RPC = False
         try:
             cursor = self.getCursor()
 
@@ -239,14 +245,15 @@ def editRPCServer(self, protocol, host, user, passwd, id):
                            "WHERE id = ?",
                            (protocol, host, user, passwd, id)
                            )
-
-            self.app.sig_changed_rpcServers.emit()
+            changed_RPC = True
 
         except Exception as e:
             err_msg = 'error editing RPC server entry to DB'
             printException(getCallerName(), getFunctionName(), err_msg, e.args)       
         finally:
-            self.releaseCursor()   
+            self.releaseCursor()
+            if changed_RPC:
+                self.app.sig_changed_rpcServers.emit()   
 
 
 
@@ -287,19 +294,21 @@ def getRPCServers(self, custom, id=None):
 
 
     def removeRPCServer(self, index):
+        removed_RPC = False
         try:
             cursor = self.getCursor()
             cursor.execute("DELETE FROM RPC_SERVERS"
                            " WHERE id=?", (index,))
-
-            self.app.sig_changed_rpcServers.emit()
+            removed_RPC = True
 
         except Exception as e:
             err_msg = 'error removing RPC servers from database'
             printException(getCallerName(), getFunctionName(), err_msg, e.args)
 
         finally:
             self.releaseCursor()
+            if removed_RPC:
+                self.app.sig_changed_rpcServers.emit()
 
 
 

src/version.txt

@@ -1,5 +1,5 @@
 {
  "number": "0.3.99",
- "tag": "n",
- "comments": ["update specfile"]
+ "tag": "o",
+ "comments": ["DB signals fix"]
  }