Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce helm chart #248

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

hurzelpurzel
Copy link

No description provided.

@hurzelpurzel
Copy link
Author

add buildkit to dapper

@hurzelpurzel hurzelpurzel marked this pull request as draft July 4, 2023 12:43
@hurzelpurzel hurzelpurzel marked this pull request as ready for review July 4, 2023 12:43
@hurzelpurzel hurzelpurzel marked this pull request as draft July 4, 2023 12:46
@hurzelpurzel hurzelpurzel marked this pull request as ready for review July 4, 2023 12:46
@hurzelpurzel hurzelpurzel marked this pull request as draft July 4, 2023 12:49
@hurzelpurzel hurzelpurzel marked this pull request as ready for review July 4, 2023 12:49
@hurzelpurzel hurzelpurzel marked this pull request as draft July 4, 2023 12:52
@hurzelpurzel hurzelpurzel marked this pull request as ready for review July 4, 2023 12:52
@hurzelpurzel
Copy link
Author

Sorry the build fails, but this has nothing todo with my changes. I'm not able to fix it. It seems to be a docker issue

@hurzelpurzel
Copy link
Author

After disabling Buildkit the buid works

serviceAccountName: system-upgrade
upgrade:
image: rancher/k3s-upgrade
version: v1.24.6+k3s1
Copy link

@larivierec larivierec Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know if this is exactly relevant, but this should match the version of kubectl you're deploying with.

or at least, it should be an input in values.yaml

allowing users to change a few things will allow better customization.

and versions should always be customizable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be an artifact of wrestling with docker+buildkit, is it necessary to enable your chart contribution?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. when disabling buildkit the build works

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/rancher/system-upgrade-controller/pull/248/files#r1269672413:

this seems to be an artifact of wrestling with docker+buildkit, is it necessary to enable your chart contribution?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted my changes that disabled the build kit stuff and add helm chart variables as requested. Please add this to the master branch.
Since I'm not familiar with drone, I'm not able to implement the helm chart packaging and pushing to the github repository. That could be a enhancement. Nevertheless the helm chart might help users.

@brandond
Copy link
Member

Is there any way you can consume the CRDs from the build artifacts, instead of maintaining a static copy in the chart dir?

@hurzelpurzel
Copy link
Author

@brandond: I think it is a good idea. In addition I would like to package the helm during the build. But I'm not familiar with the build process, Could you please tell me how to integrate a helm package step after the usual build where the crd.yaml is created ?
Addionally i would relocate it to a crd subfolder according to https://helm.sh/docs/chart_best_practices/custom_resource_definitions/. So please can you tell me how I can change and test the built process ?

@onedr0p
Copy link

onedr0p commented Aug 25, 2023

I tried bringing up something related here #172 (comment)

@lexfrei
Copy link

lexfrei commented Feb 29, 2024

Any news?

@brandond
Copy link
Member

Would you mind updating this to reflect recent changes to the RBAC?

@lexfrei
Copy link

lexfrei commented Feb 29, 2024

Maybe if you need help, but not in March. Too busy on a new work.

@brandond
Copy link
Member

That was intended for the PR author.

@Marvin0098
Copy link

👀

@mysticaltech
Copy link

@hurzelpurzel Recent kustomization issues involving the latest tag broke our project, we need this helm chart.

@Marvin0098
Copy link

I'm using parts of this helm chart from the PR already to create plans. An official helm chart would be awesome and highly appreciated.

@hurzelpurzel
Copy link
Author

Recently synced my forked repo. Is there anymore that I can do ? Or what is blocking the merge ?

@Marvin0098
Copy link

They are not using the cluster admin role anymore, check the latest release 0.13.4

@onedr0p
Copy link

onedr0p commented Mar 28, 2024

Unfortunately even if this was merged, I don't see any workflow to publish the Helm chart anywhere.

@Marvin0098
Copy link

Unfortunately even if this was merged, I don't see any workflow to publish the Helm chart anywhere.

I could look into that

@simonfelding
Copy link

I suggested a helm release action here https://github.com/hurzelpurzel/system-upgrade-controller/pull/1/files
But it requires some additional setup by the owners.
From the documentation:

Pre-requisites
One of these confuguration
A GitHub repo containing a single chart in root directory (Chart.yaml)
A directory with your Helm charts (default is a folder named /charts, if you want to maintain your charts in a different directory, you must include a settings.charts_dir input in the plugin settings).
GitHub branch called gh-pages to store the published charts.
In your repo, go to Settings/Pages. Change the Source Branch to gh-pages.
Create a .drone.yml file in your root directory. Pipelines examples are available below. For more information, reference the Drone CI Help Documentation for Pipeline Overview

@hurzelpurzel
Copy link
Author

hurzelpurzel commented Apr 3, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants