-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce helm chart #248
base: master
Are you sure you want to change the base?
introduce helm chart #248
Conversation
add buildkit to dapper |
Sorry the build fails, but this has nothing todo with my changes. I'm not able to fix it. It seems to be a docker issue |
After disabling Buildkit the buid works |
serviceAccountName: system-upgrade | ||
upgrade: | ||
image: rancher/k3s-upgrade | ||
version: v1.24.6+k3s1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't know if this is exactly relevant, but this should match the version of kubectl you're deploying with.
or at least, it should be an input in values.yaml
allowing users to change a few things will allow better customization.
and versions should always be customizable
scripts/package-controller
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to be an artifact of wrestling with docker+buildkit, is it necessary to enable your chart contribution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no. when disabling buildkit the build works
scripts/package-e2e-tests
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/rancher/system-upgrade-controller/pull/248/files#r1269672413:
this seems to be an artifact of wrestling with docker+buildkit, is it necessary to enable your chart contribution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted my changes that disabled the build kit stuff and add helm chart variables as requested. Please add this to the master branch.
Since I'm not familiar with drone, I'm not able to implement the helm chart packaging and pushing to the github repository. That could be a enhancement. Nevertheless the helm chart might help users.
Is there any way you can consume the CRDs from the build artifacts, instead of maintaining a static copy in the chart dir? |
@brandond: I think it is a good idea. In addition I would like to package the helm during the build. But I'm not familiar with the build process, Could you please tell me how to integrate a helm package step after the usual build where the crd.yaml is created ? |
I tried bringing up something related here #172 (comment) |
Any news? |
Would you mind updating this to reflect recent changes to the RBAC? |
Maybe if you need help, but not in March. Too busy on a new work. |
That was intended for the PR author. |
👀 |
@hurzelpurzel Recent kustomization issues involving the latest tag broke our project, we need this helm chart. |
I'm using parts of this helm chart from the PR already to create plans. An official helm chart would be awesome and highly appreciated. |
Recently synced my forked repo. Is there anymore that I can do ? Or what is blocking the merge ? |
They are not using the cluster admin role anymore, check the latest release 0.13.4 |
Unfortunately even if this was merged, I don't see any workflow to publish the Helm chart anywhere. |
I could look into that |
I suggested a helm release action here https://github.com/hurzelpurzel/system-upgrade-controller/pull/1/files
|
Will try To-Do as suggested
simonfelding ***@***.***> schrieb am Mi., 3. Apr. 2024, 10:28:
… I suggested a helm release action here
https://github.com/hurzelpurzel/system-upgrade-controller/pull/1/files
But it requires some additional setup by the owners.
From the documentation
<https://github.com/otwld/drone-chart-releaser-github-pages>:
Pre-requisites
One of these confuguration
A GitHub repo containing a single chart in root directory (Chart.yaml)
A directory with your Helm charts (default is a folder named /charts, if
you want to maintain your charts in a different directory, you must include
a settings.charts_dir input in the plugin settings).
GitHub branch called gh-pages to store the published charts.
In your repo, go to Settings/Pages. Change the Source Branch to gh-pages.
Create a .drone.yml file in your root directory. Pipelines examples
<https://github.com/otwld/drone-chart-releaser-github-pages#example-pipeline>
are available below. For more information, reference the Drone CI Help
Documentation for Pipeline Overview
<https://docs.drone.io/pipeline/overview/>
—
Reply to this email directly, view it on GitHub
<#248 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADACKDTNHJMT6ZCJOIQ5JE3Y3O4UDAVCNFSM6AAAAAAZ5VNRGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZTHEYDCNRVGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No description provided.