Fix e2e ci by ignoring FOG warnings #7267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
brandond
approved these changes
Nov 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7267 +/- ##
==========================================
- Coverage 23.70% 8.99% -14.72%
==========================================
Files 33 33
Lines 3392 3392
==========================================
- Hits 804 305 -499
- Misses 2541 3064 +523
+ Partials 47 23 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
VestigeJ
approved these changes
Nov 12, 2024
dereknola
added a commit
to dereknola/rke2
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/rke2
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/rke2
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/rke2
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Derek Nola <[email protected]>
This was referenced Nov 12, 2024
dereknola
added a commit
that referenced
this pull request
Nov 13, 2024
Signed-off-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The latest version of vagrant-libvirt current suffers from an error around FOG warnings being constantly produced on any call of
vagrant ssh. For now we will simply remove these warnings from any output returnTypes of Changes
Verification
CI is once again green
Testing
Linked Issues
N/A nothing to QA
User-Facing Change
Further Comments