Add extra log in e2e tests #5955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Buil <[email protected]>
brandond
approved these changes
May 23, 2024
thomasferrandiz
approved these changes
May 28, 2024
manuelbuil
added a commit
to manuelbuil/rke2
that referenced
this pull request
May 28, 2024
Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
added a commit
to manuelbuil/rke2
that referenced
this pull request
May 28, 2024
Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
added a commit
to manuelbuil/rke2
that referenced
this pull request
May 28, 2024
Signed-off-by: Manuel Buil <[email protected]>
This was referenced May 28, 2024
manuelbuil
added a commit
that referenced
this pull request
May 29, 2024
Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
added a commit
that referenced
this pull request
May 29, 2024
Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
added a commit
that referenced
this pull request
May 29, 2024
Signed-off-by: Manuel Buil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
As of today, when running rke2 e2e tests, we can see how the server-0 is created. For example:
But we don't see the same log for the rest of VMs which might be confusing. This PR removes that confusion as now the test will print all
vagrant upcommands it runsTypes of Changes
Extra logging
Verification
Run an e2e test that creates several VMs and you now should see the
vagrant upcommand for all nodes, not just server-0Example:
Testing
Linked Issues
User-Facing Change
Further Comments