Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note how to prune scheduled snapshots #247

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Add note how to prune scheduled snapshots #247

merged 1 commit into from
Aug 21, 2024

Conversation

dereknola
Copy link
Member

  • After recent triage, clarify that to manually prune scheduled snapshots, you need to give the --name etcd-snapshot

@dereknola dereknola requested a review from a team as a code owner August 15, 2024 16:23
brandond
brandond approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should add an --all option to the command? To prune everything regardless of snapshot name.

@dereknola
Copy link
Member Author

That would be a good idea

@dereknola dereknola merged commit 521ce8e into rancher:main Aug 21, 2024
1 check passed
@dereknola dereknola deleted the etcd-snap branch September 5, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorsavian vitorsavian vitorsavian approved these changes

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereknola @brandond @vitorsavian