Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update disable charts #127

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Update disable charts #127

merged 3 commits into from
Nov 27, 2023

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Nov 20, 2023 •
edited
Loading

Changes

  • Adds missing charts that you can disable.
  • Replaces list with an yaml example config to be clear how the disable flag interacts as a list, not just a single value

Addresses: #123
Signed-off-by: Derek Nola [email protected]

@dereknola
Update disable charts
65c98d3 
Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola requested a review from a team as a code owner November 20, 2023 20:20
brandond
brandond reviewed Nov 20, 2023
View reviewed changes
docs/advanced.md Outdated Show resolved Hide resolved
@dereknola dereknola merged commit 8d0b208 into rancher:main Nov 27, 2023
1 check passed
@dereknola dereknola deleted the disable_extra branch November 27, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandowns briandowns briandowns approved these changes

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereknola @brandond @briandowns