Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rke2-agent restart step to Certificate Rotation #107

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

masap
Copy link
Contributor

@masap masap commented Sep 27, 2023

We need to restart rke2-agent to rotate certificates of agent nodes.

@masap masap requested a review from a team as a code owner September 27, 2023 05:58
docs/advanced.md Outdated
@@ -18,6 +18,10 @@ systemctl stop rke2-server
rke2 certificate rotate
systemctl start rke2-server
```
After certificate rotation of server, restart rke2-agent as well to rotate kubelet certificates in worker nodes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this actually belongs here. Agent certificates are renewed every time the agent starts, so this command can actually be done at any time, independent from server certificate rotation.

We should also make it clear that this service should be restarted on agent nodes only, to avoid having users try to restart the agent service on servers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandond Thank you for comment.

I'm not sure this actually belongs here. Agent certificates are renewed every time the agent starts, so this command can actually be done at any time, independent from server certificate rotation.

Right, only restarting rke2-agent is needed. I fixed document.

We should also make it clear that this service should be restarted on agent nodes only, to avoid having users try to restart the agent service on servers.

I also added the statement to run on agent node and confirmed restarting rke2-agent renewed certificates at /var/lib/rancher/rke2/agent/.

We need to restart rke2-agent to rotate certificates of agent nodes.

Signed-off-by: Masashi Honma <[email protected]>
@dereknola dereknola merged commit c1f50c0 into rancher:main Oct 3, 2023
1 check passed
@masap masap deleted the fix-cert-rotation branch October 4, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants