Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows ami does not exist #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

strophy
Copy link

@strophy strophy commented Jun 20, 2024

Resolves #224

Following the AWS quickstart instructions results in the following Terraform error:

│ Error: Your query returned no results. Please change your search criteria and try again.
│ 
│   with data.aws_ami.windows,
│   on data.tf line 32, in data "aws_ami" "windows":
│   32: data "aws_ami" "windows" {
│ 

This AMI no longer exists. When the fix in this PR is applied, it matches ami-06404b83fffc8f0ca in my eu-west-3 region, and resolves to Windows_Server-2019-English-Full-SQL_2019_Web-2024.06.13.

@MASisserson
Copy link

I'd like to second that this PR be merged with main.

@wombelix
Copy link

wombelix commented Oct 8, 2024

I would highly appreciate a fix for #224 but suggest that values = ["Windows_Server-2019-English-Full-Base*"] is used. Otherwise other flavours like SQL Server or Core are part of the results too. Doesn't matter to get rid of the error message when setting add_windows_node = false. But might have an unexpected side effect if someone wants to deploy Windows nodes.

wombelix added a commit to wombelix/fork_rancher_quickstart that referenced this pull request Nov 8, 2024
Filter for 'Windows_Server-2019-English-Full-Base*' to avoid that flavours like SQL Server or Core are part of the results.

Refs: rancher#236 (comment)
@strophy
Copy link
Author

strophy commented Dec 6, 2024

Good point @wombelix, I made the change according to your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS] Fail to search the Windows Server AMI
3 participants