Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy report results to dashboard view #819

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

jordojordo
Copy link
Member

@jordojordo jordojordo commented Jul 26, 2024

Fix #798

This adds policy report results to the dashboard view.

Along with the reports added, the layout of the cards has been updated.

  • The Policy Servers card has been moved to the end
  • Both policy types no longer show the ConsumptionGuage component showing their status
  • Events gauge is now displayed in place of the policy status gauge
  • The Create buttons have been moved into the header of the card

dashboard

@jordojordo jordojordo added the kind/enhancement New feature or request label Jul 26, 2024
@jordojordo jordojordo added this to the 2.0.x milestone Jul 26, 2024
@jordojordo jordojordo self-assigned this Jul 26, 2024
@jordojordo jordojordo marked this pull request as ready for review August 15, 2024 18:01
@kravciak
Copy link
Collaborator

Functionality-wise I did not find any problem. I have few suggestions / notes about my initial confusion :)

  • It's not obvious what Success/Fail/Error mean - should I be scared of red progress bar?
  • Rename Events to Compliance / Reports /...?
  • Clickable Pass/Fail/Error events so I can take closer look (link to Policy Reporter?)
  • Align policy servers progress bar to bottom
  • Different Create .. button color if any resource already exists - feature?
  • Unify colors:
    • Policy Servers: blue & yellow & red & grey
      proposal: change ok from blue to green to match policies
    • Policies: green & red & orange
      proposal: fail = yellow, error=red (fail is just a warning in this case, right?)
      what does error mean - how can I generate error events?

Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise, LGTM

@jordojordo
Copy link
Member Author

Holding off on this until the UX team can take a look.

@jordojordo
Copy link
Member Author

@kravciak I've updated the reports to fix those issues you mentioned after a discussion with the UX team.

dashboard

Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM

@jordojordo jordojordo modified the milestones: 2.1.x, 3.0.0, 3.0.x Nov 8, 2024
@kravciak
Copy link
Collaborator

kravciak commented Nov 8, 2024

It works fine, just one note - could we show empty bar even if no reports are found?

Screenshot from 2024-11-08 14-28-09

@jordojordo
Copy link
Member Author

Here's the updated version with an empty bar:

dashboard

@kravciak
Copy link
Collaborator

kravciak commented Nov 8, 2024

Empty bar is black, is that by intention?

Screenshot from 2024-11-08 16-05-16

@jordojordo
Copy link
Member Author

Forgot to check how the bar looked in light mode, should be the correct color now.

@jordojordo jordojordo merged commit dd17965 into rancher:main Nov 8, 2024
1 check failed
@jordojordo jordojordo deleted the dashboard-updates branch November 8, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add PolicyReports to the Kubewarden Dashboard
3 participants