Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a custom lint rule to ensure we use v-clean-tooltip instead of v-tooltip directives. #12633

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codyrancher
Copy link
Contributor

@codyrancher codyrancher commented Nov 20, 2024

Summary

Wanted to automate the ability to detect one of our common sources of XSS issues. I wrote a custom linter rule so we can catch this in CI.

Technical notes summary

I noticed that we currently exclude linting rancher-components from our root directory. I'd think we'd just want to include everything but I'm not sure.

Areas or cases that should be tested

None, it's in a way an additional test.

Areas which could experience regressions

None

Screenshot/Video

Example:
image

You can disable the rule in the template using:
image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@codyrancher codyrancher changed the title Adding a custom lint rule to ensure we use v-clean-tooltip instead of… Adding a custom lint rule to ensure we use v-clean-tooltip instead of v-tooltip directives. Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant