Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.10] rancher-cis-benchmark auto-bump 105.0.1 #4786

Merged

Conversation

nicholasSUSE
Copy link
Collaborator

Auto bumping rancher-cis-benchmark

@nicholasSUSE nicholasSUSE requested a review from a team as a code owner November 27, 2024 15:06
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@@ -23,8 +23,10 @@ neuvector-monitor:
- 105.0.0+up2.8.3
rancher-cis-benchmark:
- 105.0.0+up7.0.0
- 105.0.1+up7.0.1
rancher-cis-benchmark-crd:
- 105.0.0+up7.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicholasSUSE this version is already released right? shouldnt it be removed already?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should be removed but it does not break anything.
I will be removing it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and thanks for reviewing!

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@nicholasSUSE nicholasSUSE changed the title [dev-v2.10] Rancher cis benchmark 105.0.1 [dev-v2.10] rancher-cis-benchmark auto-bump 105.0.1 Nov 27, 2024
Copy link
Contributor

@mitulshah-suse mitulshah-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicholasSUSE nicholasSUSE merged commit 266c554 into rancher:dev-v2.10 Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants