Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): return key exists error instead of bubbling up a SQL error #38

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(storage): return key exists error instead of bubbling up a SQL error #38

merged 1 commit into from
Nov 19, 2024

Conversation

fabriziosestito
Copy link
Collaborator

Return key exists error instead of bubbling up a SQL error.

@fabriziosestito fabriziosestito added bug Something isn't working storage labels Nov 18, 2024
@fabriziosestito fabriziosestito self-assigned this Nov 18, 2024
@fabriziosestito fabriziosestito added this to the MVP milestone Nov 18, 2024
flavio
flavio approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabriziosestito fabriziosestito merged commit 8cff6f7 into rancher-sandbox:main Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavio flavio flavio approved these changes

Assignees

@fabriziosestito fabriziosestito

Labels
bug Something isn't working storage
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.
2 participants
@fabriziosestito @flavio