Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old, problematic, and unnecessary renderError and clearError method defaults #491

Closed

Conversation

cpsievert
Copy link
Collaborator

Closes #490

By removing these defaults, when the widget is in rendered in Shiny, it will simply fallback to Shiny's OutputBinding default methods, which does a better and simpler job of rendering and clearing errors.

And, when rendering statically, the renderError/clearError methods aren't relevant

…ror and clearError method defaults

By removing these defaults, when the widget is in rendered in Shiny, it will simply fallback to Shiny's OutputBinding default methods, which does a better and simpler job of rendering and clearing errors.

And, when rendering statically, the renderError/clearError methods aren't relevant
@cpsievert cpsievert requested a review from gadenbuie December 12, 2024 19:39
@cpsievert
Copy link
Collaborator Author

cpsievert commented Dec 13, 2024

After looking at this again, I now realize there is an intentional difference here and the generic output binding renderError. In the widget case, when an error gets rendered after a widget has been rendered, the widget container's height doesn't change, meaning there is no reflow of content below it. This isn't the case for something like uiOutput().

We could still move away from the setTimeout() to ResizeObserver(), but that's another matter.

@cpsievert cpsievert closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widget HTML containers have visibility:hidden; when an error is rendered
1 participant