Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restores eager recursion into options objects #478

Merged
merged 3 commits into from
Nov 27, 2023
Merged

fix: Restores eager recursion into options objects #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de342f4
Partially revert 7c5594a10bdd74d8f4ece178d31ae97c4592c351
gadenbuie Nov 25, 2023
57f407e
fix(shouldEval): Avoid recursion into POSIXlt objects
gadenbuie Nov 27, 2023
2c48a70
docs: Add news item
gadenbuie Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# htmlwidgets (development version)

* htmlwidgets once again eagerly recurses into list-like objects when searching for JavaScript strings wrapped in `JS()`. If you encounter an infinite recursion ("C stack usage is too close to the limit"), the best strategy is to coerce the offending items to a character string. (#478)

# htmlwidgets 1.6.3

### Potentially breaking changes
Expand Down
3 changes: 2 additions & 1 deletion R/utils.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ JSEvals <- function(list) {
#' @noRd
#' @keywords internal
shouldEval <- function(options) {
if (inherits(options, c("list", "data.frame"))) {
if (is.list(options)) {
if (inherits(options, "POSIXlt")) return(FALSE)
if ((n <- length(options)) == 0) return(FALSE)
# use numeric indices as names (remember JS indexes from 0, hence -1 here)
if (is.null(names(options)))
Expand Down
Loading