Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of html-fill-item-overflow-hidden class #472

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Remove use of html-fill-item-overflow-hidden class #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c39930
Remove use of html-fill-item-overflow-hidden class
cpsievert Sep 7, 2023
91968f7
Apply suggestions from code review
cpsievert Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ URL: https://github.com/ramnathv/htmlwidgets
BugReports: https://github.com/ramnathv/htmlwidgets/issues
Imports:
grDevices,
htmltools (>= 0.5.4),
htmltools (>= 0.5.7),
jsonlite (>= 0.9.16),
knitr (>= 1.8),
rmarkdown,
Expand Down
16 changes: 2 additions & 14 deletions R/htmlwidgets.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,14 +183,7 @@ toHTML <- function(x, standalone = FALSE, knitrOptions = NULL) {
width = validateCssUnit(sizeInfo$width),
height = validateCssUnit(sizeInfo$height),
),
class = paste(
name, "html-widget",
# bindFillRole() puts `overflow:auto` to items by default,
# which is a sensible generic default, but in the context of
# widgets, we can pretty easily run into non-pixel-perfect situations
# (e.g., the widget JS uses something like offsetHeight to resize itself)
if (sizeInfo$fill) "html-fill-item-overflow-hidden"
),
class = paste(name, "html-widget"),
width = sizeInfo$width,
height = sizeInfo$height
)
Expand Down Expand Up @@ -488,12 +481,7 @@ shinyWidgetOutput <- function(outputId, name, width, height, package = name,
class = paste0(
name, " html-widget html-widget-output",
if (reportSize) " shiny-report-size",
if (reportTheme) " shiny-report-theme",
# bindFillRole() puts `overflow:auto` to items by default,
# which is a sensible generic default, but in the context of
# widgets, we can pretty easily run into non-pixel-perfect situations
# (e.g., the widget JS uses something like offsetHeight to resize itself)
if (fill) " html-fill-item-overflow-hidden"
if (reportTheme) " shiny-report-theme"
),
style = css(
width = validateCssUnit(width),
Expand Down
Loading