handle more bower cases with bower install in scaffoldWidget #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timelyportfolio
force-pushed
the
fix-bower-morecases
branch
from
340ac68 to
782a360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice but certainly nothing to delay or interfere with CRAN submission
As I tested alternate cases with bower, I ran into problems, since these lines in
readBowerassume the primary and popular use case ofbower installwith a package in the bower registry. The alternate unpopular but potentially problematic cases would be Github shorthand or a direct Github url. I added a tiny bit of code to handle these cases by usingbasename()and also removing".git".