Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect an 'after_widget' field to control the order of dependencies #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cpsievert
Copy link
Collaborator

@jcheng5
Copy link
Collaborator

jcheng5 commented Feb 3, 2017

I was going to suggest adding a separate field into the widget object (in addition to dependencies) for dependencies that are prerequisites. But are there cases where you have a prerequisite dependency that isn't known until runtime? (I.e. can't go into the yaml)

@cpsievert
Copy link
Collaborator Author

Yeah. IIRC, that was a roadblock for plotly/plotly.R#411 since mathjax needed to appear before the plotly.js bundle.

@jjallaire
Copy link
Collaborator

jjallaire commented Feb 3, 2017 via email

@cpsievert
Copy link
Collaborator Author

@jjallaire it seems as though forgoing yaml dependencies entirely can lead to weird loading issues (they differ in certain contexts?) -- see plotly/plotly.R#1033. Any idea on the best way to proceed?

@jjallaire
Copy link
Collaborator

I am unsure about how YAML dependencies would differ from explicitly specified ones. @ramnathv or @jcheng5 any idea?

@ramnathv
Copy link
Owner

@jjallaire @jcheng5 I think the issue is that htmlwidgets always looks for a YAML file containing dependencies. We can update it to check for a YAML file and fetch dependencies only if it contains one. This should solve the problem encountered. I will start a new branch with the fix so @cpsievert can try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants