TLS Version Pinning #264
Open
TLS Version Pinning #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
heywill support TLS version pinning. I chose to support all the TLS versions that the Golang TLS package supports.The utility now accepts 2 new parameters:
-min-tls-versionand-max-tls-version. You can specify one, both, or none of them. A check is made to ensure that you don't specify the min above the max (min 1.2 max 1.0 will throw error).This feature is useful to ensure that you are using the proper TLS version in requests. I also used this to test out performance of TLS 1.2 vs TLS 1.3.
For testing, I implemented table-driven tests to create a number of test cases in a succinct manner.