Fix docker stop() behavior

raisenational · Oct 15, 2023 · a5d16f3 · a5d16f3
1 parent f2c4848
commit a5d16f3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/start.ts b/src/start.ts
@@ -115,7 +115,7 @@ export const start = async (customOptions?: Partial<StartOptions>): Promise<void
   }
 
   const commonArgs = ['-jar', jarFilename, '-port', String(options.port)];
-  const dockerArgs = ['run', '-d', '-p', `${options.port}:${options.port}`, options.dockerImage];
+  const dockerArgs = ['run', '-p', `${options.port}:${options.port}`, options.dockerImage];
   if (options.install_path) {
     deprecation('Use installPath instead of install_path');
   }

diff --git a/src/stop.ts b/src/stop.ts
@@ -3,7 +3,7 @@ import { instances } from './instances';
 export const stop = async (port: number): Promise<void> => {
   const instance = instances.get(port);
   if (instance) {
-    instance.process.kill('SIGKILL');
+    instance.process.kill('SIGTERM');
     instances.delete(port);
   }
 };