Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circular peer dependencies blocking updates #1383

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Fix circular peer dependencies blocking updates #1383

merged 5 commits into from
Mar 22, 2024

Conversation

CreativeTechGuy
Copy link
Contributor

@CreativeTechGuy CreativeTechGuy commented Mar 21, 2024 •
edited
Loading

Fixes #1382

This also fixes an issue (no clue how it never caused an error) where calling packageManager.getPeerDependencies with a version range (eg: ^1.2.3) would cause the function to return an array instead of the expected object.

@CreativeTechGuy CreativeTechGuy marked this pull request as draft March 21, 2024 00:24
@CreativeTechGuy CreativeTechGuy marked this pull request as ready for review March 21, 2024 05:56
raineorshine
raineorshine requested changes Mar 21, 2024
View reviewed changes
Copy link
Owner

@raineorshine raineorshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few questions/comments.

test/peer.test.ts Outdated Show resolved Hide resolved
test/peer.test.ts Outdated Show resolved Hide resolved
src/lib/getPeerDependenciesFromRegistry.ts Outdated Show resolved Hide resolved
src/lib/isCircularPeer.ts Outdated Show resolved Hide resolved
src/lib/getPeerDependenciesFromRegistry.ts Show resolved Hide resolved
@CreativeTechGuy
Copy link
Contributor Author

I resolved a many things as I could, a few follow up questions though.

@CreativeTechGuy
Copy link
Contributor Author

Okay I think I've addressed everything. Let me know if there's anything else you'd like me to change! :)

@raineorshine raineorshine merged commit c9fe908 into raineorshine:main Mar 22, 2024
8 checks passed
@raineorshine
Copy link
Owner

raineorshine commented Mar 22, 2024 •
edited
Loading

Thanks!

Published to v17.0.0-2 on the next tag.

(The main branch contains breaking changes and is on track for a major version release on latest, but is currently blocked by a few PR's. v16.x is hotfixes only at this point.)

@CreativeTechGuy
Copy link
Contributor Author

Awesome! Thank you for your help here.

@raineorshine raineorshine mentioned this pull request Aug 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raineorshine raineorshine raineorshine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to upgrade packages which are circular peer dependencies
2 participants
@CreativeTechGuy @raineorshine