Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace globby with fast-glob #1373

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

Torathion
Copy link
Contributor

@Torathion Torathion commented Mar 8, 2024

I realized that globby uses fast-glob under the hood. So, globby is just a wrapper package with some extra options.

Also, I micro-optimized two things:

  • I made the options into a constant, so it won't rebuild the options object every time
  • You unnecessarily copied the output of one glob function.

The other change is just prettier being prettier.

@Torathion
Copy link
Contributor Author

Oh, I haven't updated the package-lock.json. Uno momento

Copy link
Owner

@raineorshine raineorshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@raineorshine raineorshine merged commit b1a92b0 into raineorshine:main Mar 8, 2024
10 checks passed
@Torathion Torathion deleted the replace-globby branch March 8, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants