Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esm #1358

Closed
wants to merge 15 commits into from
Closed

esm #1358

wants to merge 15 commits into from

Conversation

raineorshine
Copy link
Owner

@raineorshine raineorshine commented Dec 18, 2023

Convert from CommonJS to ESM.

@raineorshine raineorshine changed the title Convert to esm esm Dec 18, 2023
@raineorshine raineorshine changed the base branch from main to 16.10.9 December 18, 2023 02:53
@raineorshine raineorshine changed the base branch from 16.10.9 to main December 18, 2023 02:53
@raineorshine
Copy link
Owner Author

@wmertens I haven't been able to figure out how to get esm working. If you have any interest in taking a stab at it, let me know. It's the only thing remaining for the v17 release.

@wmertens
Copy link
Contributor

wmertens commented Apr 1, 2024

I have a working branch, I'll push later today. Needed to switch to vitest because mocha wasn't happy with esm and ts

@raineorshine raineorshine force-pushed the main branch 3 times, most recently from 26c7b5c to bc18c92 Compare April 26, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants