feat: when packages are filter due to engine not matching, we need to…

… print it out, just like we do in peer checks #1422
raineorshine · Jun 15, 2024 · d127cbd · d127cbd
1 parent 52f59c1
commit d127cbd
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 7 deletions.
diff --git a/src/lib/getEnginesNodeFromRegistry.ts b/src/lib/getEnginesNodeFromRegistry.ts
@@ -23,7 +23,7 @@ async function getEnginesNodeFromRegistry(packageMap: Index<Version>, options: O
   }
 
   return Object.entries(packageMap).reduce(async (accumPromise, [pkg, version]) => {
-    const enginesNode = (await packageManager.getEngines!(pkg, version)).node
+    const enginesNode = (await packageManager.getEngines!(pkg, version, options)).node
     if (bar) {
       bar.tick()
     }

diff --git a/src/package-managers/npm.ts b/src/package-managers/npm.ts
@@ -46,6 +46,7 @@ const fetchPartialPackument = async (
   fields: (keyof Packument)[],
   tag: string | null,
   opts: npmRegistryFetch.FetchOptions = {},
+  version?: Version,
 ): Promise<Partial<Packument>> => {
   const corgiDoc = 'application/vnd.npm.install-v1+json; q=1.0, application/json; q=0.8, */*'
   const fullDoc = 'application/json'
@@ -58,7 +59,10 @@ const fetchPartialPackument = async (
     accept: opts.fullMetadata ? fullDoc : corgiDoc,
     ...opts.headers,
   }
-  const url = path.join(registry, name)
+  let url = path.join(registry, name)
+  if (version) {
+    url = path.join(url, version)
+  }
   const fetchOptions = {
     ...opts,
     headers,
@@ -672,10 +676,24 @@ export const getPeerDependencies = async (packageName: string, version: Version)
  * @param version
  * @returns Promised engines collection
  */
-export const getEngines = async (packageName: string, version: Version): Promise<Index<Version | undefined>> => {
-  const args = ['view', `${packageName}@${version}`, 'engines']
-  const result = await spawnNpm(args, {}, { rejectOnError: false })
-  return result ? parseJson<{ node?: string }>(result, { command: [...args, '--json'].join(' ') }) : {}
+export const getEngines = async (
+  packageName: string,
+  version: Version,
+  options: Options = {},
+  npmConfigLocal?: NpmConfig,
+): Promise<Index<Version | undefined>> => {
+  const result = await fetchPartialPackument(
+    packageName,
+    [`engines`],
+    null,
+    {
+      ...npmConfigLocal,
+      ...npmConfig,
+      ...(options.registry ? { registry: options.registry, silent: true } : null),
+    },
+    version,
+  )
+  return result.engines || {}
 }
 
 /**

diff --git a/src/types/PackageManager.ts b/src/types/PackageManager.ts
@@ -1,5 +1,6 @@
 import { GetVersion } from './GetVersion'
 import { Index } from './IndexType'
+import { NpmConfig } from './NpmConfig'
 import { Options } from './Options'
 import { Version } from './Version'
 import { VersionSpec } from './VersionSpec'
@@ -21,5 +22,10 @@ export interface PackageManager {
     options?: Options,
   ) => Promise<boolean>
   getPeerDependencies?: (packageName: string, version: Version) => Promise<Index<Version>>
-  getEngines?: (packageName: string, version: Version) => Promise<Index<VersionSpec | undefined>>
+  getEngines?: (
+    packageName: string,
+    version: Version,
+    options: Options,
+    npmConfigLocal?: NpmConfig,
+  ) => Promise<Index<VersionSpec | undefined>>
 }