loading railtoolkit schema via LazyArtifacts #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
gwehrle
reviewed
Jul 1, 2024
# Conflicts: # test/highlevel_test.jl # test/runtests.jl
kaat0
force-pushed
the
redesign
branch
3 times, most recently
from
c4abcb5 to
5a09430
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Currently two targets fail:
|
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path()andTrain()validate the data in the constructor with JsonSchema.Introduced two new functions
load()andget_schema(), to change from hard-coded JsonSchema to using the JsonSchema via LazyArtifacts.Path()andTrain()now useload()for a file.load()returns a validated Dict() according to the files specified JsonSchema (which has to be registered beforehand in the Artifacts.toml file).Dependencies will also be needed for issue #11.