remove special handling of inverse boolean flags #475
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #417 (comment).
This is a superset of #473, removing all special handling of boolean flags generating/parsing the inverse. It certainly makes the behavior more straightforward (no magic flags), though I realize checks for "negative" flags (like
options[:no_public] == true
) become a little more confusing. Thoughts? Also, I'm new to this codebase, so while all tests are passing, would love another set of 👀 to ensure I got everything.