Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove special handling of inverse boolean flags #475

Closed
wants to merge 2 commits into from

Conversation

afeld
Copy link

@afeld afeld commented Jan 30, 2015

⚠️ WIP ⚠️

Closes #417 (comment).

This is a superset of #473, removing all special handling of boolean flags generating/parsing the inverse. It certainly makes the behavior more straightforward (no magic flags), though I realize checks for "negative" flags (like options[:no_public] == true) become a little more confusing. Thoughts? Also, I'm new to this codebase, so while all tests are passing, would love another set of 👀 to ensure I got everything.

@fny
Copy link

fny commented May 11, 2015

I just ran into this when wrapping an AWS CLI command that had a --no-verify-ssl option. Thor ended up spitting out --no-verify-ssl and --no-no-verify-ssl.

In certain cases, it would be nice if there was a way to get both through a specified type (e.g. :magic_boolean).

@rafaelfranca
Copy link
Member

See #473 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow suppression of auto-created 'no-' flags for boolean options
3 participants