Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a missing method #root for the development configurator #147

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Define a missing method #root for the development configurator #147

merged 1 commit into from
Mar 5, 2024

Conversation

sato11
Copy link
Contributor

@sato11 sato11 commented Mar 4, 2024

This fixes an unexpected NoMethodError that experimenting through bin/console causes:

irb(main):001> Kredis.string "mystring"

/rails/kredis/lib/kredis/connections.rb:15:in `block in configured_for': undefined method `root' for an instance of #<Class:0x0000000108091a60> (NoMethodError)

      if configurator.root.join("config/redis/#{name}.yml").exist?
                     ^^^^^

This is a follow-up to #135.

This fixes an unexpected NoMethodError that experimenting through `bin/console` causes:

```
irb(main):001> Kredis.string "mystring"

/rails/kredis/lib/kredis/connections.rb:15:in `block in configured_for': undefined method `root' for an instance of #<Class:0x0000000108091a60> (NoMethodError)

      if configurator.root.join("config/redis/#{name}.yml").exist?
                     ^^^^^
```

This is a follow-up to #135.
@jeremy jeremy merged commit 57cedf5 into rails:main Mar 5, 2024
13 checks passed
@sato11 sato11 deleted the missing-method-root branch March 7, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants