Resolve a bug that caused initialization to fail in some cases (#620)

* Try to throw new Error * Fix the bug * Test logging * Fix test? * Test throws error now?
rage · Jun 29, 2021 · 8c52f13 · 8c52f13
1 parent ff0d708
commit 8c52f13
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## [2.0.3] - 2021-06-28
+
+#### Fixed
+- Bug when migrating Session state that caused extension to fail initialization in some cases.
+
 ## [2.0.2] - 2021-04-13
 
 #### Fixed

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
     "name": "test-my-code",
     "displayName": "TestMyCode",
     "description": "TestMyCode extension for Visual Studio Code",
-    "version": "2.0.2",
+    "version": "2.0.3",
     "license": "MIT",
     "publisher": "moocfi",
     "repository": {

diff --git a/src/migrate/migrateSessionState.ts b/src/migrate/migrateSessionState.ts
@@ -8,7 +8,7 @@ const SESSION_STATE_KEY_V1 = "session-state-v1";
 const UNSTABLE_EXTENSION_VERSION_KEY = "extensionVersion";
 
 export interface SessionStateV1 {
-    extensionVersion: string | undefined;
+    extensionVersion?: string | undefined;
 }
 
 /**

diff --git a/src/migrate/validateData.ts b/src/migrate/validateData.ts
@@ -7,7 +7,7 @@ export default function validateData<T>(
     }
 
     if (!validator(data)) {
-        throw Error(`Data type missmatch: ${JSON.stringify(data)}`);
+        throw new Error(`Data type missmatch: ${JSON.stringify(data)}`);
     }
 
     return data;

diff --git a/src/test/migrate/migrateSessionState.test.ts b/src/test/migrate/migrateSessionState.test.ts
@@ -52,7 +52,7 @@ suite("Session state migration", function () {
 
     suite("with stable data", function () {
         test("fails with garbage version 1 data", async function () {
-            await memento.update(SESSION_STATE_KEY_V1, { wonderwoman: "Diana Prince" });
+            await memento.update(SESSION_STATE_KEY_V1, { extensionVersion: 1 });
             expect(() => migrateSessionState(memento)).to.throw(/missmatch/);
         });
     });