-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2346 - data files load tests #3388
base: develop
Are you sure you want to change the base?
Conversation
@@ -558,3 +558,6 @@ class Common(Configuration): | |||
BULK_CREATE_BATCH_SIZE = os.getenv("BULK_CREATE_BATCH_SIZE", 10000) | |||
MEDIAN_LINE_PARSE_TIME = os.getenv("MEDIAN_LINE_PARSE_TIME", 0.0005574226379394531) | |||
BYPASS_OFA_AUTH = os.getenv("BYPASS_OFA_AUTH", False) | |||
|
|||
CELERY_WORKER_SEND_TASK_EVENTS = True | |||
CELERY_TASK_SEND_SENT_EVENT = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should i leave these on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could move them to the local.py
settings since they will only work there for the time being.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3388 +/- ##
========================================
Coverage 91.48% 91.48%
========================================
Files 299 299
Lines 8595 8595
Branches 636 636
========================================
Hits 7863 7863
Misses 615 615
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
const body = { | ||
file: http.file(file, 'loadtest-file.txt'), | ||
original_filename: 'ADS.E2J.FTP2.TS06', | ||
user: 'f94b3a2e-4ee5-4d4b-bab3-20147cb6f480', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! i updated it so it pulls the user id from the login/cypress
endpoint. caveat is that it would only work when logged in as the admin user (unless we update the endpoint)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, nice work!
Summary of Changes
Pull request closes #2346
How to Test
task k6 SCRIPT=tests/data-files.js
task k6 SCENARIO={api|browser} SCRIPT=tests/data-files.js
loadProfile
by updating thescenarios
object inperformance-tests/tests/data-files.js
- NOTE: if there's interest, we can have thetask k6
command take aLOAD_PROFILE
arg similar toSCENARIO
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):