Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.7.5 release notes and knowledge center updates #3382

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

victoriaatraft
Copy link

Summary of Changes

Release notes and knowledge center updates
Pull request closes #3316

How to Test

List the steps to test the PR
These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d
cd tdrs-backend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d 
  1. Open http://localhost:3000/ and sign in.
  2. Proceed with functional tests as described herein.
  3. Test steps should be captured in the demo GIF(s) and/or screenshots below.

Demo GIF(s) and screenshots for testing procedure

@victoriaatraft victoriaatraft self-assigned this Dec 17, 2024
@victoriaatraft victoriaatraft requested review from lfrohlich and removed request for reitermb December 17, 2024 22:13
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (62fde87) to head (41341d4).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3382   +/-   ##
========================================
  Coverage    91.48%   91.48%           
========================================
  Files          299      299           
  Lines         8595     8595           
  Branches       636      636           
========================================
  Hits          7863     7863           
  Misses         615      615           
  Partials       117      117           
Flag Coverage Δ
dev-backend 91.32% <ø> (ø)
dev-frontend 92.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62fde87...41341d4. Read the comment docs.

@@ -693,6 +715,182 @@ <h4>File Pre-Check: Errors related to record length:</h4>

<p>Please refer to the <a href="https://www.acf.hhs.gov/ofa/policy-guidance/final-tanf-ssp-moe-data-reporting-system-transmission-files-layouts-and-edits">Transmission File Layout documents</a> to compare your records against their expected layouts.</p>


<table class="usa-table">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed this addition. very nice 🚀

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ADPennington Noting a couple small tweaks I just committed, we were generating some a11y errors off of the table for empty primary columns (The original program type column). Changes:

  • Eliminated that column by splitting the table up into three by program
  • Replaced >= type notations with ≥ for better screenreader behavior

Resulting in:
image

cc @victoriaatraft

Copy link
Collaborator

@ADPennington ADPennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@reitermb reitermb self-requested a review December 17, 2024 22:58
@reitermb
Copy link

A11y scans:
image
image
image

Copy link
Collaborator

@klinkoberstar klinkoberstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ADPennington
Copy link
Collaborator

@reitermb @victoriaatraft will this merge soon?

@victoriaatraft
Copy link
Author

victoriaatraft commented Dec 19, 2024

Hi, sorry I thought this has been merged. I noticed on the Gitbok process page that this step has not been assigned to anyone.

Preference on who takes ownership of this task? It comes after Dev cuts the release, so I would think it would be dev? Happy to be wrong on that. I'm assuming it's selecting the "merge pull request" button? @ADPennington
cc @reitermb @klinkoberstar @lhuxraft

edit: i noticed on the list of tasks in the design ticket I had OFA merges PR to Knowledge Center after release is pushed to production, so i can definitely make that correction moving forward once we decide who takes ownership of that task....

next update: Andrew said I can press it and it's not scary anymore so I can assign it to UX once pr's get approved lol.

@victoriaatraft victoriaatraft merged commit ccd2ca8 into develop Dec 19, 2024
12 checks passed
@victoriaatraft victoriaatraft deleted the 3.7.5-release-notes branch December 19, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v 3.7.5 Release Notes and Knowledge Center Updates
5 participants