-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.7.5 release notes and knowledge center updates #3382
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3382 +/- ##
========================================
Coverage 91.48% 91.48%
========================================
Files 299 299
Lines 8595 8595
Branches 636 636
========================================
Hits 7863 7863
Misses 615 615
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
@@ -693,6 +715,182 @@ <h4>File Pre-Check: Errors related to record length:</h4> | |||
|
|||
<p>Please refer to the <a href="https://www.acf.hhs.gov/ofa/policy-guidance/final-tanf-ssp-moe-data-reporting-system-transmission-files-layouts-and-edits">Transmission File Layout documents</a> to compare your records against their expected layouts.</p> | |||
|
|||
|
|||
<table class="usa-table"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noticed this addition. very nice 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ADPennington Noting a couple small tweaks I just committed, we were generating some a11y errors off of the table for empty primary columns (The original program type column). Changes:
- Eliminated that column by splitting the table up into three by program
- Replaced >= type notations with ≥ for better screenreader behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@reitermb @victoriaatraft will this merge soon? |
Hi, sorry I thought this has been merged. I noticed on the Gitbok process page that this step has not been assigned to anyone. Preference on who takes ownership of this task? It comes after Dev cuts the release, so I would think it would be dev? Happy to be wrong on that. I'm assuming it's selecting the "merge pull request" button? @ADPennington edit: i noticed on the list of tasks in the design ticket I had OFA merges PR to Knowledge Center after release is pushed to production, so i can definitely make that correction moving forward once we decide who takes ownership of that task.... next update: Andrew said I can press it and it's not scary anymore so I can assign it to UX once pr's get approved lol. |
Summary of Changes
Release notes and knowledge center updates
Pull request closes #3316
How to Test
List the steps to test the PR
These steps are generic, please adjust as necessary.