Reprocessed Modal: Submission History #3343

elipe17 · 2024-12-06T17:12:10Z

Summary of Changes

Add ReprocessedModal component
Use new component in submission history tables
Pull request closes Reprocessed on enhancement (3014 follow-on) #3271

How to Test

List the steps to test the PR
These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose up --build
cd tdrs-backend && docker-compose up

Open http://localhost:3000/ and sign in.
Submit some files.
Note that the Reprocessed button isn't visible in submission history
Reparse some/all of the files you submitted
You should now see the Reprocessed button is visible in submission history for the files you reparsed
Click the button and you should see a modal with the latest reparse date and explanation

In the raft environment use the following STT, year, and quarter to easily view the changes: Arizona Year:2021 and Quarter:1

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

Submitted on/by columns are combined
Dialog has a close button
Dialog contains paragraph explainer on reprocessing
Dialog contains date time stamp for last reprocessing event
Dialog opens when trigger in Submitted on column is clicked
UX has been pinged to ticket knowledge center revisions to capture these changes
Testing Checklist has been run and all tests pass
README is updated, if necessary

Deliverable 2: Tested Code

Are all areas of code introduced in this PR meaningfully tested?
- If this PR introduces backend code changes, are they meaningfully tested?
- If this PR introduces frontend code changes, are they meaningfully tested?
Are code coverage minimums met?
- Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
- Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

Are backend code style checks passing on CircleCI?
Are frontend code style checks passing on CircleCI?
Are code maintainability principles being followed?

Deliverable 4: Accessible

Does this PR complete the epic?
Are links included to any other gov-approved PRs associated with epic?
Does PR include documentation for Raft's a11y review?
Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

Does this PR provide background for why coding decisions were made?
If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
If this PR introduces dependencies, are their licenses documented?
Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

Does the OWASP Scan pass on CircleCI?
Do manual code review and manual testing detect any new security issues?
If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

the purpose of the research
methods used to conduct the research
who participated in the research
what was tested and how
impact of research on TDP
(if applicable) final design mockups produced for TDP development

- Add ReprocessedModal component - Use new component for submission history tables

codecov · 2024-12-06T17:12:47Z

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.57%. Comparing base (08c346a) to head (defdbea).
Report is 9 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../components/SubmissionHistory/ReprocessedModal.jsx	60.00%	4 Missing ⚠️
tdrs-frontend/src/components/Modal/Modal.jsx	50.00%	2 Missing ⚠️
...ponents/SubmissionHistory/TotalAggregatesTable.jsx	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3343      +/-   ##
===========================================
- Coverage    91.61%   91.57%   -0.05%     
===========================================
  Files          298      298              
  Lines         8520     8526       +6     
  Branches       621      621              
===========================================
+ Hits          7806     7808       +2     
- Misses         602      606       +4     
  Partials       112      112

Flag	Coverage Δ
dev-backend	`91.42% <100.00%> (ø)`
dev-frontend	`92.65% <76.66%> (-0.35%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
tdrs-backend/tdpservice/data_files/serializers.py	`96.29% <100.00%> (ø)`
tdrs-frontend/src/components/Reports/Reports.jsx	`87.61% <100.00%> (+0.22%)`	⬆️
...mponents/SubmissionHistory/CaseAggregatesTable.jsx	`92.85% <100.00%> (ø)`
...components/SubmissionHistory/SubmissionHistory.jsx	`100.00% <100.00%> (ø)`
...ntend/src/components/SubmissionHistory/helpers.jsx	`80.95% <100.00%> (ø)`
...ponents/SubmissionHistory/TotalAggregatesTable.jsx	`69.23% <80.00%> (ø)`
tdrs-frontend/src/components/Modal/Modal.jsx	`70.96% <50.00%> (-1.45%)`	⬇️
.../components/SubmissionHistory/ReprocessedModal.jsx	`60.00% <60.00%> (-27.50%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae340de...defdbea. Read the comment docs.

…3271-reparse-dialog

victoriaatraft

LGTM from an a11y perspective. @elipe17. Is it possible for the modal to also close of the user selects the grayed out area in addition to the "close" button?

- Fixed bug in Modal that caused it to crash when tabbing or shift tabbing with only one button

jtimpe

Works as written! I have a suggestion regarding the structuring of the components that I would like your thoughts on before I approve, but I'll let you decide whether to move forward with it or not.

tdrs-frontend/src/components/SubmissionHistory/CaseAggregatesTable.jsx

tdrs-frontend/src/components/SubmissionHistory/ReprocessedModal.jsx

raftmsohani

LGTM!

ADPennington · 2024-12-16T17:44:02Z

tdrs-frontend/src/components/SubmissionHistory/SubmissionHistory.test.js

@@ -474,4 +486,42 @@ describe('SubmissionHistory', () => {
      }
    }
  )
+
+  it('Shows Reprocessed button', () => {


@elipe17 do we need more tests here to capture the following scenarios:

reprocessing tribal TANF file

reprocessing SSP file

no reprocessing

Asking because I noticed that reprocessing indicators are not appearing for tribal TANF and SSP files. evidence below.

It should be the same exact logic regardless of TANF, SSP, Tribal. I just tested SSP locally and it was fine. Let me checkout the deployed env

@ADPennington I just tested in the Raft env since it is still deployed there and it is working as expected for TANF, SSP, and Tribal. Maybe we can deploy this back to qasp when you are ready and check it out together?

thank you @elipe17 -- one thing i forgot to mention is that I was testing aggregate and stratum files for SSP and tribal TANF.

Roger. I tested active, closed, and aggregate for TANF. Active and aggregate for SPP. Only active for Tribal. Let me know when you are ready to test it out and we can hop on a call or work async via the deployment

@elipe17 re-deploying now

ADPennington

changes requested re: reprocessing on tribal and SSP files.

ADPennington · 2024-12-17T16:54:41Z

@ttran-hub -- do you have some time today for a11y testing for this PR?

we need a11y testing on data file page > submission history tab, in the areas highlighted in the screenshot below. This branch is in qasp env.

@klinkoberstar can you remind me -- is there a release note associated with this?

ttran-hub · 2024-12-17T21:55:18Z

@ttran-hub -- do you have some time today for a11y testing for this PR?

we need a11y testing on data file page > submission history tab, in the areas highlighted in the screenshot below. This branch is in qasp env.

@klinkoberstar can you remind me -- is there a release note associated with this?

a111y LGTM!

ADPennington

🚀 🚀 🚀

- Add css class for reprocessed modal

186fe5b

- Add ReprocessedModal component - Use new component for submission history tables

elipe17 added frontend dev raft review This issue is ready for raft review a11y-review PR is ready for accessibility review labels Dec 6, 2024

elipe17 self-assigned this Dec 6, 2024

elipe17 added 2 commits December 6, 2024 12:21

- remove component

26bebd8

- removed unnecessary span

fc56eb5

elipe17 marked this pull request as ready for review December 6, 2024 19:49

elipe17 requested review from reitermb, andrew-jameson, raftmsohani, victoriaatraft and jtimpe December 6, 2024 20:42

Merge branch 'develop' into 3271-reparse-dialog

5809764

reitermb added the Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI label Dec 6, 2024

elipe17 added 5 commits December 9, 2024 14:44

Small fix to rowspan

224e3d3

- Add test for reprocessed button/modal

dd895c2

Merge branch 'develop' of https://github.com/raft-tech/TANF-app into …

aafa81a

…3271-reparse-dialog

- linting

75f5ba7

- linting

08c346a

elipe17 added Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI and removed Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI labels Dec 10, 2024

victoriaatraft approved these changes Dec 10, 2024

View reviewed changes

andrew-jameson approved these changes Dec 10, 2024

View reviewed changes

- Add underline text decoration

eab0955

- Fixed bug in Modal that caused it to crash when tabbing or shift tabbing with only one button

elipe17 added Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI and removed Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI labels Dec 11, 2024

jtimpe reviewed Dec 11, 2024

View reviewed changes

tdrs-frontend/src/components/SubmissionHistory/CaseAggregatesTable.jsx Outdated Show resolved Hide resolved

tdrs-frontend/src/components/SubmissionHistory/ReprocessedModal.jsx Outdated Show resolved Hide resolved

elipe17 added the QASP Review label Dec 12, 2024

elipe17 requested a review from ADPennington December 12, 2024 14:40

raftmsohani approved these changes Dec 13, 2024

View reviewed changes

ADPennington added Deploy with CircleCI-qasp Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI and removed Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI labels Dec 16, 2024

reitermb approved these changes Dec 16, 2024

View reviewed changes

ADPennington requested a review from ttran-hub December 16, 2024 17:22

ADPennington added the Gov A11y Review label Dec 16, 2024

ADPennington reviewed Dec 16, 2024

View reviewed changes

ADPennington requested changes Dec 16, 2024

View reviewed changes

- do NOT consider an unfinished reparse event to be the latest reparse

defdbea

elipe17 added the Deploy with CircleCI-qasp Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI label Dec 17, 2024

ttran-hub closed this Dec 17, 2024

ADPennington reopened this Dec 17, 2024

ADPennington approved these changes Dec 17, 2024

View reviewed changes

ADPennington added Ready to Merge and removed raft review This issue is ready for raft review Blocked Label for Pull Requests that are currently blocked by a dependency Gov A11y Review Deploy with CircleCI-qasp Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI labels Dec 17, 2024

elipe17 merged commit 4598fa1 into develop Dec 17, 2024
24 checks passed

elipe17 deleted the 3271-reparse-dialog branch December 17, 2024 22:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reprocessed Modal: Submission History #3343

Reprocessed Modal: Submission History #3343

elipe17 commented Dec 6, 2024 •

edited by ADPennington

Loading

codecov bot commented Dec 6, 2024 •

edited

Loading

victoriaatraft left a comment

jtimpe left a comment

raftmsohani left a comment

ADPennington Dec 16, 2024

elipe17 Dec 16, 2024

elipe17 Dec 16, 2024

ADPennington Dec 16, 2024

elipe17 Dec 16, 2024

ADPennington Dec 16, 2024

ADPennington left a comment

ADPennington commented Dec 17, 2024

ttran-hub commented Dec 17, 2024

ADPennington left a comment

Reprocessed Modal: Submission History #3343

Reprocessed Modal: Submission History #3343

Conversation

elipe17 commented Dec 6, 2024 • edited by ADPennington Loading

Summary of Changes

How to Test

Deliverables

codecov bot commented Dec 6, 2024 • edited Loading

Codecov Report

victoriaatraft left a comment

Choose a reason for hiding this comment

jtimpe left a comment

Choose a reason for hiding this comment

raftmsohani left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ADPennington left a comment

Choose a reason for hiding this comment

ADPennington commented Dec 17, 2024

ttran-hub commented Dec 17, 2024

ADPennington left a comment

Choose a reason for hiding this comment

elipe17 commented Dec 6, 2024 •

edited by ADPennington

Loading

codecov bot commented Dec 6, 2024 •

edited

Loading