SSP M2 CITIZENSHIP_STATUS Cat3 Update

[elipe17]

Summary of Changes

• Updated the cat3 validator to accept 3 as a valid value for CITIZENSHIP_STATUS
• Waiting on feedback to determine whether we are changing "alien" references to "non-citizen"
  Pull request closes Revise Cat 3 Validator Logic for SSP Active Case Data #3320

How to Test

cd tdrs-frontend && docker-compose up
cd tdrs-backend && docker-compose up

1. Open http://localhost:3000/ and sign in.
2. Submit a section 1 ssp file that has CITIZENSHIP_STATUS=3 and CITIZENSHIP_STATUS=9 verify no cat3 error generated when CITIZENSHIP_STATUS=3 and that a cat3 error is generated when CITIZENSHIP_STATUS=9

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

• Cat 3 Validator logic for Items 26 and 38 is revised to allow 3 as an acceptable value for citizenship .
• Error message related to Items 26 and 38 should be updated to reflect correct expected options.
• Cat 3 Validator logic for Items 60 and 69 is revised to allow 3 as an acceptable value for citizenship .
• Error message related to Items 60 and 69 should be updated to reflect correct expected options.
• references to "alien" in the codebase is changed to "non-citizen" (on hold) Alex writing new ticket for this.
• Testing Checklist has been run and all tests pass
• README is updated, if necessary

Deliverable 2: Tested Code

• Are all areas of code introduced in this PR meaningfully tested?
  • If this PR introduces backend code changes, are they meaningfully tested?
  • If this PR introduces frontend code changes, are they meaningfully tested?
• Are code coverage minimums met?
  • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
  • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

• Are backend code style checks passing on CircleCI?
• Are frontend code style checks passing on CircleCI?
• Are code maintainability principles being followed?

Deliverable 4: Accessible

• Does this PR complete the epic?
• Are links included to any other gov-approved PRs associated with epic?
• Does PR include documentation for Raft's a11y review?
• Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

• Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

• Does this PR provide background for why coding decisions were made?
• If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
• If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
• If this PR introduces dependencies, are their licenses documented?
• Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

• Does the OWASP Scan pass on CircleCI?
• Do manual code review and manual testing detect any new security issues?
• If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

• the purpose of the research
• methods used to conduct the research
• who participated in the research
• what was tested and how
• impact of research on TDP
• (if applicable) final design mockups produced for TDP development

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (c7778e5) to head (eb7f211).
Report is 10 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3338   +/-   ##
========================================
  Coverage    91.59%   91.59%           
========================================
  Files          297      297           
  Lines         8509     8509           
  Branches       621      621           
========================================
  Hits          7794     7794           
  Misses         601      601           
  Partials       114      114           

Flag	Coverage Δ
dev-backend	91.42% <ø> (ø)
dev-frontend	92.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...s-backend/tdpservice/parsers/schema_defs/ssp/m2.py	100.00% <ø> (ø)
...s-backend/tdpservice/parsers/schema_defs/ssp/m3.py	100.00% <ø> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6767fc5...eb7f211. Read the comment docs.

[ADPennington]

change requested re: this comment . I missed the related validators in the M3 record.

[ADPennington]

🚀 appreciate the quick fix @elipe17 cc: @victoriaatraft @reitermb

confirmed that the following error messages no longer present in SSP Active files:

Since Item 26 (Family Affiliation) is 1, then Item 38 (Citizenship/Immigration Status) 3 must be one of (1, 2)
Since Item 60 (Family Affiliation) is 1, then Item 69 (Citizenship/Immigration Status) 3 must be one of (1, 2)