Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/cf check #3337

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Hotfix/cf check #3337

merged 4 commits into from
Dec 4, 2024

Conversation

andrew-jameson
Copy link
Collaborator

@andrew-jameson andrew-jameson commented Dec 4, 2024

Summary of Changes

Provide a brief summary of changes
Can someone please comment the broken source pipelines that had the issue with cloudfoundry.org?

How to Test

Will need to run deployment either to develop and/or staging.

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

  • [insert ACs here]
  • lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?
    • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
    • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Are code maintainability principles being followed?

Deliverable 4: Accessible

  • Does this PR complete the epic?
  • Are links included to any other gov-approved PRs associated with epic?
  • Does PR include documentation for Raft's a11y review?
  • Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

  • Does this PR provide background for why coding decisions were made?
  • If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?
  • Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any new security issues?
  • If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

  • the purpose of the research
  • methods used to conduct the research
  • who participated in the research
  • what was tested and how
  • impact of research on TDP
  • (if applicable) final design mockups produced for TDP development

@andrew-jameson andrew-jameson self-assigned this Dec 4, 2024
@andrew-jameson andrew-jameson added the raft review This issue is ready for raft review label Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (58c69c8) to head (9481e46).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3337   +/-   ##
========================================
  Coverage    91.49%   91.49%           
========================================
  Files          297      297           
  Lines         8433     8433           
  Branches       611      611           
========================================
  Hits          7716     7716           
  Misses         604      604           
  Partials       113      113           
Flag Coverage Δ
dev-backend 91.35% <ø> (ø)
dev-frontend 92.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bba246...9481e46. Read the comment docs.

Copy link

@raftmsohani raftmsohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ADPennington
Copy link
Collaborator

@andrew-jameson feel free to bypass qasp review and merge to develop to test this solution.

@andrew-jameson andrew-jameson merged commit d4b7f76 into develop Dec 4, 2024
13 checks passed
@andrew-jameson andrew-jameson deleted the hotfix/cf-check branch December 4, 2024 19:52
@andrew-jameson andrew-jameson restored the hotfix/cf-check branch December 4, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
raft review This issue is ready for raft review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants