Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2137 ally frontend footer #3318

Merged
merged 6 commits into from
Dec 10, 2024
Merged

2137 ally frontend footer #3318

merged 6 commits into from
Dec 10, 2024

Conversation

raftmsohani
Copy link

@raftmsohani raftmsohani commented Dec 2, 2024

Summary of Changes

Provide a brief summary of changes
Pull request closes #2137 _

How to Test

  1. Open http://localhost:3000/.
  2. See that the footer links are in one line (All links in footer are housed in one list element)

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

  • [insert ACs here]
  • lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?
    • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
    • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Are code maintainability principles being followed?

Deliverable 4: Accessible

  • Does this PR complete the epic?
  • Are links included to any other gov-approved PRs associated with epic?
  • Does PR include documentation for Raft's a11y review?
  • Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

  • Does this PR provide background for why coding decisions were made?
  • If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?
  • Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any new security issues?
  • If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

  • the purpose of the research
  • methods used to conduct the research
  • who participated in the research
  • what was tested and how
  • impact of research on TDP
  • (if applicable) final design mockups produced for TDP development

@raftmsohani raftmsohani self-assigned this Dec 2, 2024
@raftmsohani raftmsohani added frontend a11y Accessibility/Section 508 a11y-review PR is ready for accessibility review labels Dec 2, 2024
@raftmsohani raftmsohani requested a review from reitermb December 2, 2024 13:40
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (8f5a452) to head (6026355).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3318   +/-   ##
========================================
  Coverage    91.59%   91.59%           
========================================
  Files          297      297           
  Lines         8509     8509           
  Branches       621      621           
========================================
  Hits          7794     7794           
  Misses         601      601           
  Partials       114      114           
Flag Coverage Δ
dev-backend 91.42% <ø> (ø)
dev-frontend 92.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tdrs-frontend/src/components/Footer/Footer.jsx 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d03c3c...6026355. Read the comment docs.

@raftmsohani raftmsohani removed the request for review from andrew-jameson December 2, 2024 18:48
@reitermb reitermb added Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI and removed Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI labels Dec 4, 2024
Copy link

@reitermb reitermb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Confirming everything's in a single list now and a11y scan is clear

image

image

@ADPennington
Copy link
Collaborator

ADPennington commented Dec 6, 2024

@lhuxraft @raftmsohani i'm tagging @ttran-hub to review this ticket. please deploy this to a dev environment for a11y testing. this can merge once he approves.

@ADPennington ADPennington added the Deploy with CircleCI-qasp Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI label Dec 9, 2024
@ttran-hub
Copy link
Collaborator

@lhuxraft @raftmsohani i'm tagging @ttran-hub to review this ticket. please deploy this to a dev environment for a11y testing. this can merge once he approves.

Thanks! a11y LGMT!

Copy link
Collaborator

@ADPennington ADPennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved per @ttran-hub 🚀

@ADPennington ADPennington added Ready to Merge and removed Deploy with CircleCI-qasp Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI labels Dec 9, 2024
@raftmsohani raftmsohani merged commit 7247a50 into develop Dec 10, 2024
16 checks passed
@raftmsohani raftmsohani deleted the 2137-ally-frontend-footer branch December 10, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility/Section 508 a11y-review PR is ready for accessibility review frontend Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y] Update footer designs to address additions like vulnerability disclosure
6 participants